✎ fix commit problem in qsql_ibase.cpp [ПромАвтоматика]

Эта страница только для чтения. Вы можете посмотреть исходный текст, но не можете его изменить. Сообщите администратору, если считаете, что это неправильно.

====== fix commit problem in qsql_ibase.cpp ======

==== the problem ====
Transaction with unsuccessful commit can never be rollbacked. This migth cause some metaobjects get locked and as result hanging of any client (including itself) which tries to use that metaobjects. Example:

  - given the following:<code sql>
CREATE SEQUENCE myseq;

CREATE TABLE mytbl (id integer);

CREATE OR ALTER trigger mytrig_bi0 for mytbl
active before insert position 0
AS
begin
  new.id = next value for myseq;
end
</code>
  - qt code:<code cpp>
  QSqlDatabase db = ...
  QString sql = "drop sequence myseq";
  
  db.transaction();
  QSqlQuery q(sql, db);
  qDebug() << q.lastError().text(); // no error!
  q.close();
  db.commit();
  qDebug() << q.lastError().text(); // error: unsuccessful metadata update...
  
  // trying to drop once more time
  db.transaction();
  QSqlQuery q(sql, db); // blocked forever...
</code>

==== the solution ====
Edit file ''...qtbase/src/sql/drivers/ibase/qsql_ibase.cpp'':
<code cpp>
bool QIBaseDriver::commitTransaction()
{
    Q_D(QIBaseDriver);
    if (!isOpen() || isOpenError())
        return false;
    if (!d->trans)
        return false;

    isc_commit_transaction(d->status, &d->trans);
//    d->trans = 0;
//    return !d->isError(QT_TRANSLATE_NOOP("QIBaseDriver", "Unable to commit transaction"),
//                       QSqlError::TransactionError);

    bool res = !d->isError(QT_TRANSLATE_NOOP("QIBaseDriver", "Unable to commit transaction"),
                       QSqlError::TransactionError);
    if( !res )
        isc_rollback_transaction(d->status, &d->trans);

    d->trans = 0;

    return res;
}
</code>

==== ps ====
Prefer explicit transation start and commit as shown above as it is not possible to avoid this problem executing queries with implicit transaction control.